5 Replies to “Direct input support for polling”

  1. Anonymous says:

    I’m confused because this commit message below, Sepherosa says to NOT use direct input.


  2. mer says:

    Anonymous, you left out a very important piece of the commit message:
    “…in critical section”
    Full commit message is:
    git: polling: Don’t do direct input in critical section.

    Which is drastically different than:
    Don’t do direct input.

    Although a quick look at the patch referenced in your link, I think Sepherosa added to the polling so that higher priority interrupt sources don’t get starved.

  3. Flavio says:

    How common is it to write code for “situation [that] should not be possible to even get into”, like the commit message states below:


  4. Anonymous says:


    i agree. definitely seems odd to include code in your codebase that should never be possible to run.

  5. mer says:

    Sometimes it just means you haven’t thought of all the ways it could be run. “should never be possible” is not “impossible”. multiple cores, multiple cpus, faster cpus, sometimes what should never be possible happens.

Comments are closed.