Comments on: Yet another network optimization https://www.dragonflydigest.com/2015/10/26/yet-another-network-optimization/ A running description of activity related to DragonFly BSD. Thu, 29 Oct 2015 01:18:13 +0000 hourly 1 https://wordpress.org/?v=7.0 By: Anonymous https://www.dragonflydigest.com/2015/10/26/yet-another-network-optimization/comment-page-1/#comment-355136 Thu, 29 Oct 2015 01:18:13 +0000 http://www.dragonflydigest.com/?p=16981#comment-355136 Oh :)

Pretty accidental. But the effect is same :), it currently read:
int error = 0;

if (ai != NULL)
error = udp_preattach();

if (error) {
goto out;
} else {
/* comment */
}

I am fixing it now :)

]]> By: john https://www.dragonflydigest.com/2015/10/26/yet-another-network-optimization/comment-page-1/#comment-355113 Wed, 28 Oct 2015 14:56:26 +0000 http://www.dragonflydigest.com/?p=16981#comment-355113 hmm, s4 is correct.
I think it’s missing brackets after != NULL) myself.

]]> By: s4 https://www.dragonflydigest.com/2015/10/26/yet-another-network-optimization/comment-page-1/#comment-355106 Wed, 28 Oct 2015 13:04:32 +0000 http://www.dragonflydigest.com/?p=16981#comment-355106 There are missing brackets or wrong indentation. Most likely wrong indentation.

+ if (ai != NULL)
+ error = udp_preattach(so, 0 /* don’t care */, ai);
+ if (error)
+ goto out;
+ else {
+ /* Post attach; do nothing */
+ }

]]>